Repository navigation
[Vulcan] Clarify randomized UUIDv2 uniqueness limits - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Vulcan.
Correct the UUIDv2 “never repeat” claim and both matching C comments. Defaulted fields use randomness, not the v2 high-water mark. With a fixed node, only six random sequence bits survive the domain overwrite.
Validation on PHP 8.4.26: 1,000 fixed-node/default-sequence calls produced 64 unique UUIDs in one visible timestamp interval. V1/v6 controls each produced 1,000 unique values. Strict native build had zero warnings; 102 PHPTs passed, 3 environment skips (opcache/php-cgi); 35 guard tests passed. Independent review and merge-tree passed.
Sibling sweep: both v2 comments corrected; README/docs v1/v6 guarantees remain valid because those generators always use the shared monotonic timestamp. No generator change: GCC preprocessed base/head C compares byte-identically. Documentation only, so no new prose assertions or changelog entry (same policy as #35); no multi-PHP or sanitizer claim. Existing GUID documentation work is untouched.
Head:
148ec66c26e57a7b12d0f4cd0dcfed10e3f784c4. CI passed: all 36 Tests jobs in run 44482145063 and Check CHANGELOG.md in run 44482144783 succeeded. Peer recheck skipped, not counted as passed.